>#!/usr/bin/perl
You miss these:
use strict;
use warnings;
>my ($datafile, $tmp, $i, $line, $columns, $x, $y);
declare the variables where you use and initialize them. Not as a bunch of unrelated variables at the top of your script.
>my (@col, @dataline, @cell, %col);
You don't use these. anywhere.
>
>$datafile = $ARGV[0]; # pick up data file name from command line
>$targetfile = $ARGV[1];
>$tgtfile = $ARGV[2];
>$cntfile = $ARGV[3];
my ($datafile, $targetfile, $tgtfile, $cntfilr) = @ARGV;
>open (DATAFILE, "<$datafile") or die "Failed to open $datafile for input";
open my $dfh, "<", $datafile or die "$datafile: $!";
>open(TGT1,">$targetfile") or die $!;
open my $tfh1, ">", $targetfile or die "$tgtfile: $!";
>open(TGT2,">$tgtfile") or die $!;
open my $tfh2, ">", $tgtfile or die "$tgtfile: $!";
>while($line =
)
>{
while (<$dfh>) {
>chomp($line);
chomp;
>next unless($line =~ m/\S+/);
\S+ is stupid if a single \S is enough to get it pass
m/\S/ or next;
>@array = split("",$line);
>if(($array[11] == 2)&&($array[12] == 7))
>{
I /think you do NOT want to do it like that.
Assuming there is some structure in the lines, you either want to use substr ($_, 11, 2) or (probably better) some sort of
my ($x, $y, $code, ...) = unpack "A5 A6 A2 ...", $_;
if ($code == 27) {
see 'man perlpacktut' for some more in-depth explanation.
>$line = join("",@array);
Why reassemble the line while you never modified it?
>print TGT1 $line ."\n";
print $tfh1 $_;
$x++;
}
>$x++
>}
>else
>{
>$line = join("",@array);
>print TGT2 $line ."\n";
>$y++
>}
else {
print $tfh2 $_;
$y++;
}
}
>printf ("%010d\n",$x);
>printf ("%010d\n",$y);
printf "%010d\n%010d\n", $x, $y;
>close DATAFILE;
>close TGT1;
>close TGT2;
close $dfh or die "$datafile: $!";
close $tfh1 or die "$targetfile: $!";
close $tfh2 or die "$tgtfile: $!";
Enjoy, Have FUN! H.Merijn
Enjoy, Have FUN! H.Merijn
