topic Re: Help - cant compile c program with function in Operating System - HP-UX

Help - cant compile c program with function

Dave Chamberlin — Mon, 08 Nov 2010 18:50:18 GMT

Been awhile since I did any c programs with function declarations. This gives error 1584 (inconsistant type declaration).

Re: Help - cant compile c program with function

Matti_Kurkela — Mon, 08 Nov 2010 19:56:26 GMT

You need to list the types in your function declaration too. Listing them in the function prototype only is not enough.

Change:
----
dc(a,b)
{
----
to:
----
double dc(double a, double b)
{
----

MK

Re: Help - cant compile c program with function

Dave Chamberlin — Mon, 08 Nov 2010 20:03:14 GMT

The 1584 error is still there after changing the function to dc(double a, double b). Also tried chaning the declaration to double dc(double a, double b)

Re: Help - cant compile c program with function

Dennis Handly — Mon, 08 Nov 2010 20:26:51 GMT

>MK: Listing them in the function prototype only is not enough.

It would also help if the prototype was at file scope.

Re: Help - cant compile c program with function

Dennis Handly — Mon, 08 Nov 2010 20:45:37 GMT

>Also tried changing the declaration to: double dc(double a, double b)

What's the current source look like?

Re: Help - cant compile c program with function

Dave Chamberlin — Mon, 08 Nov 2010 20:57:22 GMT

#include
#include

int main(void)
{
double a,b,intg;
double dc(double a,double b);

a=1.0;
b=2.0;

intg=dc(a,b);
printf("sum is %g\n",intg);
}

dc(double a,double b)
{
double q;
q=a+b;
return q;
}

Re: Help - cant compile c program with function

James R. Ferguson — Mon, 08 Nov 2010 20:58:57 GMT

Hi Dave:

You didn't follow what Matti wrote:

...
double dc(double a, double b)
...

Regards!

...JRF...

Re: Help - cant compile c program with function

Dave Chamberlin — Mon, 08 Nov 2010 21:55:05 GMT

That did it - thanks!

Re: Help - cant compile c program with function

Steven Schweda — Mon, 08 Nov 2010 21:56:29 GMT

This is (well-designed) C, so no type in a
declaration is equivalent to "int", so:
dc( [...]
is equivalent to:
int dc( [...]
which is "inconsistant" with:
double dc( [...]

Does the message actually have "inconsistent"
spelled wrong, or was that your contribution?

Re: Help - cant compile c program with function

Dennis Handly — Tue, 09 Nov 2010 06:50:05 GMT

>Steven: This is (well-designed) C,

But it is obsolescent in C99, so you shouldn't code that way.

>Does the message actually have "inconsistent"
spelled wrong?

No, the PA compiler gets that right: :-)
cc: error 1584: Inconsistent type declaration: "dc".
cc: error 1711: Inconsistent parameter list declaration for "dc".

Re: Help - cant compile c program with function

Steven Schweda — Tue, 09 Nov 2010 14:34:51 GMT

> [...] you shouldn't code that way.

No argument here. I claim that
IMPLICIT NONE
was the best thing that ever happened to
FORTRAN. The amazing thing is that someone
thought that "implicit int" was a good idea
for C.

Re: Help - cant compile c program with function

TwoProc — Tue, 09 Nov 2010 15:17:21 GMT

You're right Steve.

I can remember wading through fortran just absolutely loaded with implicits from all over the place. Nasty. Really nasty when the code wasn't yours, and was written over 25 years ago, and no-one was familiar with it. All I could do was make subroutines

The worst I ever saw was in a C program that I became the chief owner of, it was a total of 250K lines of code, and in the middle of one of the longest pieces, I found the following indented over about 200 spaces to the right.

m++;

I wrote an awk script to give me a look at program flow and variable declarations. I never found it where "m" was declared, and I never found it became instantiated. The debugger was crud (it was an off brand C compiler, I forget the name) so putting a "watch" on m was impossible to see if I could watch it come to life. Ugh.

So, I commented the line out and recompiled. And nothing worked.

:-)

Dave, no points for this please, it was just an old bad memory I wanted to share for some reason.