topic Re: Spaces in file causing problems with my array in Operating System - HP-UX

Spaces in file causing problems with my array

Steve_617 — Wed, 20 Apr 2005 05:16:50 GMT

I wrote the following perl scripts but when there are multiple spaces it does not perform the way I though it should. The script looks like this
#!/usr/bin/perl -w
`rm /tmp/tmp1/*`;
`cat /home1/reports/output/ljhbdss1/tmpftp >/tmp/tmp1/tmpfile`;
`cat /home1/reports/output/lptadss1/tmpftp >>/tmp/tmp1/tmpfile`;
`cat /home1/reports/output/lblmdss1/tmpftp >>/tmp/tmp1/tmpfile`;
`cat /home1/reports/output/lctndss1/tmpftp >>/tmp/tmp1/tmpfile`;
`cat /home1/reports/output/lpthdss1/tmpftp >>/tmp/tmp1/tmpfile`;
`cat /home1/reports/output/ldbndss1/tmpftp >>/tmp/tmp1/tmpfile`;

open (FOA, " > /tmp/tmp1/tmp.avg");
open (FOT, " > /tmp/tmp1/tmp.det");
open (FI, "< /tmp/tmp1/tmpfile") or die "Cannot find ljhbdss1 tmp file";
while ($line=)
{
@LIST=(split/ /,($line));
chomp @LIST;
$var=$LIST[1];
print "creating $var\n";
sleep 1;
open (FN, ">> /tmp/tmp1/$var");
print FN @LIST,"\n";
close FN;
}
close FI;
close FOA;
close FOT;
exit

The input files has the following entries.
13.04.2005 r141DMZ1 10.203.63.6 100
14.04.2005 r141DMZ1 10.203.63.6 100
15.04.2005 r141DMZ1 10.203.63.6 100
16.04.2005 r141DMZ1 10.203.63.6 100
17.04.2005 r141DMZ1 10.203.63.6 100
18.04.2005 r141DMZ1 10.203.63.6 100
19.04.2005 r141DMZ1 10.203.63.6 100
20.04.2005 r141DMZ1 10.203.63.6 100
20.04.2005 r141DMZ1 10.203.63.6 100
r141DMZ1 Month_Availability 100.00

It bombs when reading the Month_Availability.

Can anyone show me how to eliminate the double spaces or ignore them preferably.

Regards

Re: Spaces in file causing problems with my array

harry d brown jr — Wed, 20 Apr 2005 05:28:30 GMT

tr -s "XX" "X"

REPLACE the X's with same number of SPACES

live free or die
harry d brown jr

Re: Spaces in file causing problems with my array

Steve_617 — Wed, 20 Apr 2005 05:33:56 GMT

Do I do that as part of defining the array , or after defining the array.
IE
@LIST=(split/ /,($line));
tr / / /;

Re: Spaces in file causing problems with my array

harry d brown jr — Wed, 20 Apr 2005 05:41:57 GMT

Nope,

open (FI, 'cat /tmp/tmp1/tmpfile|tr -s "XX" "X"|') or die "Cannot find ljhbdss1 tmp file";

live free or die
harry d brown jr

Re: Spaces in file causing problems with my array

Peter Godron — Wed, 20 Apr 2005 06:00:40 GMT

Steve,
where are the double spaces in your input data file?

From what I see:
read the input file
append the record to a file named as the second field

This should create 1 file called r141DMZ1 with 9 records and 1 file called Month_Availability with 1 record.
Is this correct?

Regards

Re: Spaces in file causing problems with my array

Steve_617 — Wed, 20 Apr 2005 06:11:58 GMT

Yes this is correct
But the field
r141DMZ1 Month_Availability 100.00
has spaces in between and at the end after the 100.00, causing me more greay hairs.
So it looks like this
20.04.2005 r141DMZ1 10.203.63.6 100
20.04.2005 r141DMZ1 10.203.63.6 100
r141DMZ1 Month_Availability 100.00

I would like to replace all the spaces regardless of how much with just one and obviously no spaces at the end.

Re: Spaces in file causing problems with my array

Steve_617 — Wed, 20 Apr 2005 06:28:30 GMT

I see the view removes the spaces so I will display the unwanted spaces with x's
19.04.2005 r141DMZ1 10.203.63.6 100
20.04.2005 r141DMZ1 10.203.63.6 100
20.04.2005 r141DMZ1 10.203.63.6 100
r141DMZ1 xxxMonth_Availability xxx100.00xxxx

Regards

Re: Spaces in file causing problems with my array

Peter Godron — Wed, 20 Apr 2005 06:41:05 GMT

Steve,
thanks for the details.
Can you replace the
@LIST=(split/ /,($line));
with
@LIST=(split/\s+/,($line));
and try again.

But it seems you are already happy with Harry's fix.

Regards

Re: Spaces in file causing problems with my array

H.Merijn Brand (procura — Wed, 20 Apr 2005 06:41:22 GMT

Now first let's make it more perlish

--8<---
#!/usr/bin/perl

use strict;
use warnings;

unlink ;

# Use magic open
@ARGV = map { "/home1/reports/output/$_/tmpftp" } qw( ljhbdss1 lptadss1 lblmdss1 lctndss1 lpthdss1 ldbndss1 );
while (<>) {
chomp (my @LIST = split /\s+/, $_, -1);
$var=$LIST[1];
print "creating $var\n";
sleep 1;
open my $fn, ">> /tmp/tmp1/$var" or die "$var: $!";
print $fn @LIST, "\n";
close $fn;
}
-->8---

Much more readable IMHO

I removed FOA and FOT, because they're not used in the snippet

It also splits on one or more whitespace characters

Enjoy, Have FUN! H.Merijn

Re: Spaces in file causing problems with my array

Steve_617 — Wed, 20 Apr 2005 06:59:26 GMT

Thought it was working but I am getting the following error message
Global symbol "$var" requires explicit package name at ./DayWeb.pl line 12.
Global symbol "$var" requires explicit package name at ./DayWeb.pl line 13.
Global symbol "$var" requires explicit package name at ./DayWeb.pl line 15.
Global symbol "$var" requires explicit package name at ./DayWeb.pl line 15.
Execution of ./DayWeb.pl aborted due to compilation errors.
$

Re: Spaces in file causing problems with my array

Peter Godron — Wed, 20 Apr 2005 07:13:14 GMT

Steve,
use strict; dictates amongst other things that all variables have to be declared with my()

Can you replace
$var=$LIST[1];
with
my($var)=$LIST[1];
and re-run.
Regards

Re: Spaces in file causing problems with my array

H.Merijn Brand (procura — Wed, 20 Apr 2005 07:30:04 GMT

Yes. true. sorry 'bout that.
One more thing. The lines printed in the seperate files will (or at least might) differ from the lines in the original file due to the new splitting. If you want the original lines, do this

while (<>) {
my $var = (split /\s+/, $_, -1)[1];
print "creating $var\n";
#sleep 1; # I also commented out the sleep.
open my $fn, ">> /tmp/tmp1/$var" or die "$var: $!";
print $fn;
close $fn;
}

Enjoy, Have FUN! H.Merijn [ who likes simple, short and readable code ]

Re: Spaces in file causing problems with my array

Steve_617 — Thu, 21 Apr 2005 07:05:58 GMT

Hi Guys thanks for your help.

I am still having a problem with the spaces though as it seems to remove too many spaces in SOME CASES. HEre is the output
$ more *
::::::::::::::
100.00
::::::::::::::
Month_Availability100.00
Month_Availability100.00
Month_Availability100.00
::::::::::::::
29.24
::::::::::::::
Month_Availability29.24
::::::::::::::
96.58
::::::::::::::
Month_Availability96.58
::::::::::::::
Month_Availability
::::::::::::::
r141DMZ1Month_Availability100.00
rAriviaLVL.arivia.co.zaMonth_Availability100.00
rB2B_Africa1Month_Availability100.00
rCivGermiston1Month_Availability100.00
rCivHeidelberg1Month_Availability99.53

It should in fact look like this, but some entries look like tha above with a file name = to the PErsentage

r141DMZ1
::::::::::::::
01.02.2005r141DMZ110.203.63.6100
02.02.2005r141DMZ110.203.63.6100
03.02.2005r141DMZ110.203.63.6100
04.02.2005r141DMZ110.203.63.6100
05.02.2005r141DMZ110.203.63.6100
06.02.2005r141DMZ110.203.63.6100
07.02.2005r141DMZ110.203.63.6100
08.02.2005r141DMZ110.203.63.6100
08.02.2005r141DMZ110.203.63.6100
08.02.2005r141DMZ110.203.63.6100