topic Re: Need Help On Script in Operating System - Linux

Need Help On Script

Venkat_33 — Thu, 01 Dec 2005 23:37:44 GMT

Hi guys,

I developed script contains i have some files like IMExxxxx and IMFxxxxx in /home/abc/test folder,
if it start IME it will go to IME Loop and for IMF will go to IMF Loop

if it goes to IME loop then after i want to find string IMCT and GWAY in IME Files

But i developed but it going on first loop only i.e IME Loop only

script is given below

#!/usr/bin/sh

export DIRECTORY=/home/abc/test
export DATETIME=`date +"%y%m%d%S"`
export IME=test_ime
export GSE=test_gse
export IMF=test_imf
export GWY=test_gwy
export TMP=tmp

for file in $( find $DIRECTORY -type f -name '*.*' | sort )
do
FNAME=`echo ${file} |cut -c 16-18`
echo $FNAME
STNG=$(awk '(NR==2) { print substr($0,34,4); }' ${file})
if [ $FNAME==IME ]
then
echo $STNG"hi"
if [ $STNG=="IMCT" ]
then
echo $STNG"IMCT Loop"
mv ${WRKFILE} ${DIRECTORY}/${IME}
elif [ $STNG==GWAY ]
then
echo $STNG"GWAY Loop"
mv ${WRKFILE} ${DIRECTORY}/${GWY}
fi
elif [ $FNAME==IMF ]
then
echo $FNAME"IMF Loop"
mv ${WRKFILE} ${DIRECTORY}/${IMF}
else
mv ${DIRECTORY}/${WRKFILE} ${DIRECTORY}/${GSE}
fi
done

Re: Need Help On Script

Steven E. Protter — Fri, 02 Dec 2005 01:01:11 GMT

Shalom Sir,

if [ $FNAME==IME ]
then
echo $STNG"hi"
if [ $STNG=="IMCT" ]

...

ITRC makes this very hard to read.

But it seems that IMCT is only testted for if you get a hit on IME.

I think your if/fi structure needs to be done so all items are tested for on the first loop.

Thats not how its coded now.

Also you use of quotes is inconsistent. Good shell programmers are at least consistent. Usually its better to use them than not, though it actually makes no difference if there are no whitespaces in the output.

SEP

Re: Need Help On Script

Venkat_33 — Fri, 02 Dec 2005 02:04:17 GMT

Thanks Steven,

Now my script is working and also i started develop script just a month back.

Re: Need Help On Script

Venkat_33 — Fri, 02 Dec 2005 02:04:37 GMT

Thanks a lot