topic Re: exit my scripts in Operating System - Linux

exit my scripts

lawrenzo_1 — Tue, 31 Oct 2006 06:28:25 GMT

Hello,

I have created a script to ftp files to and from an sftp server.

I have a check function within the script:

# generic check function

check () {

if [[ $? -ne 0 ]] ; then

logfile "Unix Alert: Error Processing sftp01 MRD files, please investigate"
mail -s "$DATE:$TIME:$PROGPATH/$PROGNAME has failed, please investigate" chris@mail <$LOGFILE
rm $LCKFILE

fi

My question is I want to then exit out of the entire script so I put exit 1 after the rm $LCKFILE but this then continued within the script.

what is the exit code to stop the script processing completely within the check function?

many thanks

Re: exit my scripts

Ivan Krastev — Tue, 31 Oct 2006 06:32:38 GMT

Try with :

exit 127

regards,
ivan

Re: exit my scripts

Yang Qin_1 — Tue, 31 Oct 2006 06:46:15 GMT

Try:
# generic check function

check () {

if [[ $? -ne 0 ]] ; then

logfile "Unix Alert: Error Processing sftp01 MRD files, please investigate"
mail -s "$DATE:$TIME:$PROGPATH/$PROGNAME has failed, please investigate" chris@mail <$LOGFILE
rm $LCKFILE

CODE=1

fi

exit $CODE

Yang

Re: exit my scripts

Yang Qin_1 — Tue, 31 Oct 2006 06:48:12 GMT

Sorry, forget to define CODE before "if"

# generic check function

CODE=0

check () {

if [[ $? -ne 0 ]] ; then

logfile "Unix Alert: Error Processing sftp01 MRD files, please investigate"
mail -s "$DATE:$TIME:$PROGPATH/$PROGNAME has failed, please investigate" chris@mail <$LOGFILE
rm $LCKFILE

CODE=1

fi

exit $CODE

Yang

Re: exit my scripts

James R. Ferguson — Tue, 31 Oct 2006 06:51:54 GMT

Hi:

Your code should perform as you want if you call the 'check' function immediately after a command that you want to evaulate for success. If you need to do several commands, but check only the status of the first command later in your code, you would need to do something like:

#!/usr/bin/sh
check () {
if [[ $1 -ne 0 ]] ; then
echo "non-zero; exiting..."
exit 1
fi
}
cp #...produces a non-zero return...
X=$?
date
check ${X}
echo "oops!"
exit 0

...Are you sure that your code meets this requirement?

Regards!

...JRF...

Re: exit my scripts

lawrenzo_1 — Tue, 31 Oct 2006 07:07:10 GMT

here is an example of my code:

set_env

check () {

if [[ $? -ne 0 ]] ; then

logfile "Unix Alert: Error Processing sftp01 MRD files, please investigate"
mail -s "$DATE:$TIME:$PROGPATH/$PROGNAME has failed, please investigate" chris@mail <$LOGFILE
rm $LCKFILE

fi

}

logfile () {

MSG_STRING="$*"
echo "$DATE:$TIME: $MSG_STRING" >> $LOGFILE

}

ftp code .......... >> ftp script

./ftpscript
check

ftp code .......... >> ftp script2

./ftpscript2
check

ftp code ........... >> ftp script3

./ftpscript3
check

logfile " Finished processing ftp "

If the script encounters any error's then I want it to exit here however I have noticed ftp1 failing then the check mails abd the script will then continue.

Re: exit my scripts

James R. Ferguson — Tue, 31 Oct 2006 08:06:48 GMT

Hi (again):

How does your FTP script determine the success for failure of the FTP it does?

If you are relying on a non-zero return value from an FTP to denote a failed FTP, then that is a problem.

Your FTP script needs to examine the result of its transfer in the reply it returns. As documented in the 'ftpd(1M)' manpages, this is a three-digit code. For example, a value of 226 might indicate a successful transfer. You need to capture this dialog; examine it; and construct your own zero (0) or one (1) exit status from your FTP script. In that fashinon, your 'check' function will work as expected.

Regards!

...JRF...

Re: exit my scripts

Yang Qin_1 — Tue, 31 Oct 2006 08:21:13 GMT

set_env

RET=0

check () {

if [[ $? -ne 0 ]] ; then

logfile "Unix Alert: Error Processing sftp01 MRD files, please investigate"
mail -s "$DATE:$TIME:$PROGPATH/$PROGNAME has failed, please investigate" chris@mail <$LOGFILE
rm $LCKFILE

RET=1

fi

}

logfile () {

MSG_STRING="$*"
echo "$DATE:$TIME: $MSG_STRING" >> $LOGFILE

}

ftp code .......... >> ftp script

./ftpscript
check

if [ $RET -ne 0 ] ; then
exit 1
fi

ftp code .......... >> ftp script2

./ftpscript2
check

if [ $RET -ne 0 ] ; then
exit 1
fi

ftp code ........... >> ftp script3

./ftpscript3
check

if [ $RET -ne 0 ] ; then
exit 1
fi

logfile " Finished processing ftp "

Yang

Re: exit my scripts

Peter Nikitka — Tue, 31 Oct 2006 10:26:10 GMT

Hi,

there's no need of global variables - set a return value for your check function:

check () { [ $1 -eq 0 ] && return 0
logfile ...
mail -s ...
rm ...
return $1
}

create-ftpscript >ftpscript1

ftpscript1
if ! check $?
then exit $? # this will be the ret.val of check()
fi

...

mfG Peter

Re: exit my scripts

lawrenzo_1 — Tue, 31 Oct 2006 11:16:35 GMT

James,

Thanks for your comments, I am not particulaly interested in the FTP'd file itself because if the file transfer is a failure then it will be picked up again elsewhere.

I am looking for failures within the transfer process - ie if one ftp failed then the script must stop so when run next time the remaining files processed.

I will attach the script as it is now.

Pete,

can you elaborate on your comments as I am not sure of the syntax here - as I can see yang has the solution?

Thanks for your help - if you have any idea's then I will take them onboard.

cheers

Re: exit my scripts

James R. Ferguson — Tue, 31 Oct 2006 11:49:29 GMT

Hi (again) Lawrenzo:

As I suspected, you are assuming that a failed FTP transfer is going to be reflected in the exit status from the FTP. It is *not*.

Consider the guts of the FTP process handling:

...
| ftp -in -v >> ${FTPLOGF} 2>&1

RESULTS=`awk 'BEGIN{X=1};
{if (tolower($0)~/^226 transfer complete/) {X=0}};
{if (tolower($0)~/^226 transfer finished successfully/) {X=0}};
END{print X}' ${FTPLOGF}`

if [ "${RESULTS}" != 0 ]; then
postalert "'${REQUEST}' failed"
...

This captures the verbose dialog of the FTP in ${FTPLOGF}; parses the dialog looking for an indication of a successful transfer; and sets an exit status based on the parsed text.

Be advised that the actual message text from the FTP session may differ depending upon the software in use. Thus, you may have to adjust the code. The three-digit FTP reply is documented in the manpages for 'ftpd(1M)' as I previously noted.

Regards!

...JRF...

Re: exit my scripts

Peter Nikitka — Tue, 31 Oct 2006 12:00:36 GMT

Hi,

the syntax is exactly as written, you have to add your real strings after the '...' only.

#!/usr/bin/ksh

check () { [ $1 -eq 0 ] && return 0
logfile ...
mail -s ...
rm ...
return $1
}

# here are your script generator command(s)
create-ftpscript >./ftpscript1

./ftpscript1
# this is plain ksh/posix-Shell syntax:
if ! check $?
then exit $? # this will be the ret.val of check()
fi

# add your additional code here
...

mfG Peter

Re: exit my scripts

lawrenzo_1 — Wed, 01 Nov 2006 06:26:18 GMT

thanks everone for your help ....

James and Peter solutions worked best however all idea's have been appreciated.

Chris.