topic Re: problem getting the correct filename in Operating System - OpenVMS

problem getting the correct filename

nipun_2 — Mon, 27 Feb 2006 12:44:18 GMT

Hi,
I have problem renaming a file. In my case it is DICOM File

I am passing the complete file path as a an argument in 'p1' and 'p2'
The way I give it to file

"$@''IPL_FILE' ''AIMFILE' ''DICOMFILE'"

so p1 is

AIMFILE := 'DEV''DIR''FILENAME'.AIM

p2 is

DICOMFILE := 'DEV''DIR''FILENAME'.DCM

And here is the script attached. I need to use

"dicomFilename"

So I am having trouble at
$ dicomFilename := F$PARSE(p2,,,"DIRECTORY") + filename

as a symbol
where i would need that
dicomFilename is a symbol containg "disk1:[dir1.dir2]chk"

Please let me know if you require further clarification

Re: problem getting the correct filename

Uwe Zessin — Mon, 27 Feb 2006 13:33:35 GMT

Nipun,
if I understand the problem correctly, you just need to use this (not ":=", but a simple "="):

$ dicomFilename = F$PARSE(p2,,,"DIRECTORY") + filename

Re: problem getting the correct filename

Lawrence Czlapinski — Mon, 27 Feb 2006 13:35:16 GMT

nipon:
Try dicomFilename:='F$PARSE(p2,,,"DIRECTORY")'+'filename'

$DIR = "[SYS_MGMT.logs]"
$DICOMFILE:='DEV''DIR'FILENAME.DCM
$DEV = "DSA0:"
$DIR = "[SYS_MGMT.logs]"
$filename:=change_check.log
$DICOMFILE:='DEV''DIR''FILENAME' !all Single quotes
$P2=DICOMFILE
$dicomFilename:='F$PARSE(P2,,,"DIRECTORY")'+'FILENAME'
ASDEV1Â» sh sym dicomfilename
DICOMFILENAME = "[SYS_MGMT.LOGS]+CHANGE_CHECK.LOG"
Lawrence

Re: problem getting the correct filename

Phillip Thayer — Mon, 27 Feb 2006 13:36:04 GMT

On the line:

dicomFilename := F$PARSE(p2,,,"DIRECTORY") + filename

Remove the ":" in front of the "=" so that it would be as follows:

dicomFilename = F$PARSE(p2,,,"DIRECTORY") + filename

and this should work.

Phil

Re: problem getting the correct filename

Lawrence Czlapinski — Mon, 27 Feb 2006 13:43:10 GMT

Nipon: As Uwe said = works.
If you use, ":=" whatever is behind it is intrepeted as ASCII strings, so you would need single quotes around both parts to have DCL translate both parts correctly.
Lawrence

Re: problem getting the correct filename

Uwe Zessin — Mon, 27 Feb 2006 13:51:44 GMT

Doesn't work for me, Lawrence:

$ A="12"
$ B="34"
$
$ C:='A'+'B'
$ show symbol C
C = "12+34"
$

A slightly different version that does not work either:

$ C:="''A'"+"''B'"
$ show symbol C
C = "12+34"
$

This works:
$ C=A+B
$ show symbol C
C = "1234"
$

And this:
$ C="''A'"+"''B'"
$ show symbol C
C = "1234"
$

Re: problem getting the correct filename

nipun_2 — Mon, 27 Feb 2006 14:38:26 GMT

thanks for the reply guys,
That worked however I have to do F$Parse in a different way.

However, I can't seem to go into the "IF loop"

I want to have the option that if some user writes

filename = "test" file

it should go into the IF LOOP so that we can have that name of the file

otherwise go the normal way.

Currently I feel it just doesn't enter the IF Subroutine.

I am reattaching the script file. Please let me know what I am doing wrong.

Re: problem getting the correct filename

nipun_2 — Mon, 27 Feb 2006 14:38:43 GMT

Re: problem getting the correct filename

Uwe Zessin — Mon, 27 Feb 2006 14:53:15 GMT

I don't see a loop, but let me allow a few comments / questions:

> $ filename = default

Do you have a symbol named "DEFAULT" or did you intend this:
$ filename = "default"

>$ dicomFilename = p2 - F$PARSE(p2,,,"VERSION") - ".DCM" - F$PARSE(p1,,,"NAME")+ filename
>$ dicomFilename = filename

The second command overwrites the result of the first command. I don't know if this is intentional, because there is no explanation what parameters the command procedure is supplied, but I see that the first command line uses |P1| and |P2|.

>$ EXIT
>$ ENDIF

Note that the procedure will always EXIT here when the symbol |filename| is a non-empty string and "ipl_scanco_prog" will not execute.

> -dicom_filename "dicomFilename

I guess this line is read by the program named "ipl_scanco_m.exe", but please note that DCL does not translate the value of the symbol |dicomFilename| for you.

Re: problem getting the correct filename

nipun_2 — Mon, 27 Feb 2006 19:09:49 GMT

Hi Uwe,
Thanks for the detailed analysis. By loop I meant the "IF loop"

I want it to enter the loop if the user keeps the variable

filename = ""

I removed

"EXIT"

command from the IF subroutine. But I think I am still unable to enter the IF subroutine. I have attached the file again with the changes.

Regarding

filename = "default" (I intentionally kept it to see whether it comes up)

>$ dicomFilename = p2 - F$PARSE(p2,,,"VERSION") - ".DCM" - F$PARSE(p1,,,"NAME")+ filename
>$ dicomFilename = filename

The repition above was because I was not clear whether it does enter the sub-routine and is unable to do the parsing or just skips it.

Regarding p1 and p2 they are input arguments.

regaring IPL yeah from then it goes into a seprate application which is fine. I did not wish to eliminate that part for overall clarity.

Pleas let me know if you require further information or clarification.

Re: problem getting the correct filename

Karl Rohwedder — Tue, 28 Feb 2006 00:50:24 GMT

$ IF filename .ne. ""
$ THEN
$! dicomFilename = p2 - F$PARSE(p2,,,"VERSION") - ".DCM" - F$PARSE(p1,,,"NAME")+ filename
$ dicomFilename = filename
$ ENDIF

Shouldn't that be ".nes." instead of ".ne."?
You are comparing strings.

regards Kalle

Re: problem getting the correct filename

Lawrence Czlapinski — Tue, 28 Feb 2006 20:34:10 GMT

Uwe:
I didn't realize my original statement was ambiguous.
"If you use, ":=" whatever is behind it is interpeted as ASCII strings, so you would need single quotes around both parts to have DCL translate both parts correctly." typo corrected
First, single quotes are required for each symbol not the plus sign. Without the single quotes, DCL adds the characters to the string being defined. There are parsing exceptions including single quote and double quotes.
You didn't follow the whole example I gave.
$DICOMFILE:='DEV''DIR''FILENAME' !all Single quotes
There is no "+" sign.

When combining strings, you don't normally need a "+" sign.
ASDEV1Â» a="12"
ASDEV1Â» b="34"
ASDEV1Â» c:='a''b'
ASDEV1Â» sh sym c
C = "1234"

For
$dicomFilename:='F$PARSE(P2,,,"DIRECTORY")'+'FILENAME'
if you use ":=", you need single quotes for both parts, otherwise you only get the directory part. For this line you do need the "+" sign if you use ":=". This is probably because of the lexical translation.

ASDEV1Â» c:='a'+'b'
ASDEV1Â» sh sym c
C = "12+34"
ASDEV1Â» c:=a+b
ASDEV1Â» sh sym c
C = "A+B"
ASDEV1Â» c:='a+'b
ASDEV1Â» sh sym c
C = "12+34"
ASDEV1Â» c:=ab
ASDEV1Â» sh sym c
C = "AB"
Lawrence

Re: problem getting the correct filename

Lawrence Czlapinski — Tue, 28 Feb 2006 20:46:41 GMT

nipun: Put the lexical parts of dicomfilename into symbols in your development debug version. Then you can have debug show symbol statements to show what DCL is getting for the parts and for dicomfilename. After you are satisfied, comment them out.
Lawrence

Re: problem getting the correct filename

Uwe Zessin — Wed, 01 Mar 2006 05:40:11 GMT

Yes, I got confused by this statement from you:
> Try dicomFilename:='F$PARSE(p2,,,"DIRECTORY")'+'filename'

Thanks for the correction.